handle empty but defined SHELL env #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes SHELL can be '', which should be treated the same as undefined.
Closed
|
I think this makes sense as a fix, but I would like to understand why I see this behavior some of the time ...will keep looking... |
|
This looks good, merging. |
|
This looks good, actually merging ;-) |
takluyver
added a commit
that referenced
this pull request
Apr 13, 2015
handle empty but defined SHELL env
jdfreder
referenced
this pull request
in jdfreder/notebook
Apr 23, 2015
Fix js-tests for new default selector logic.
minrk
pushed a commit
that referenced
this pull request
Feb 9, 2016
use session.deserialize to unpack message for rate limiting
ivanov
pushed a commit
that referenced
this pull request
Jan 26, 2017
drag modal dialogs by the header only
gutow
pushed a commit
to gutow/notebook
that referenced
this pull request
Jul 21, 2019
using quill.on to get into edit mode when cell is selected
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes SHELL can be '', which should be treated the same as undefined.
closes #4