Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make markdown cells stay RTL in edit mode #5037

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

m2-farzan
Copy link
Contributor

In RTL mode, rendered markdown cells show in RTL direction. However, when I want to edit them, they become LTR. This makes them unusable for writing as the problem is not merely about the alignment, but also the direction of text flow. See below:


BEFORE ENTERING EDIT MODE:

ja


AFTER ENTERING EDIT MODE:

jb


This PR fixes the bug, without affecting the actual code cells:

jc

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added this to the 6.1 milestone Jun 3, 2020
@blink1073 blink1073 merged commit 2ac0ff3 into jupyter:master Jun 3, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants