Ensure jupyter config dir exist #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug: When - the user login for the first file with a token and want to change his/her password - and if the folder `~/.jupyter` (`jupyter_config_dir()`) does not exist then the jupyter server will raise a `FileNotFoundError` exception and return a 500 error. This change tries to fix this bug by ensure the folder exist so that the `config_file` can be opened.
takluyver
reviewed
Nov 24, 2019
notebook/auth/security.py
Outdated
| @@ -118,6 +118,7 @@ def persist_config(config_file=None, mode=0o600): | |||
| """ | |||
|
|
|||
| if config_file is None: | |||
| os.makedirs(jupyter_config_dir(), exist_ok=True) | |||
There was a problem hiding this comment.
I think this should be outside the if block, and use os.path.dirname(), so it works the same way if a path is passed in explicitly.
|
An alpha release of nbconvert has broken notebook's tests, so we're stalled until someone gets to figuring that out and fixing it (I'm not sure yet if it needs changes in the tests or in nbconvert). Other than that, I think this looks good. |
|
sure, let's wait for that. |
|
Close/reopen to rerun tests with master. |
|
Thanks! |
29 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug: when
~/.jupyter(jupyter_config_dir()) does not existthen the jupyter server will raise a
FileNotFoundErrorexception and return a 500 error.This change tries to fix this bug by ensuring the folder exists so that the
config_filecan be opened.