Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated encoding parameter for Python 3.9 compatibility. #5174

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Remove deprecated encoding parameter for Python 3.9 compatibility. #5174

merged 1 commit into from
Jan 23, 2020

Conversation

tirkarthi
Copy link
Contributor

Fixes #5165

kevin-bates
kevin-bates approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you.

@minrk minrk merged commit 43df5af into jupyter:master Jan 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevin-bates kevin-bates kevin-bates approved these changes

Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encoding parameter to json.loads is deprecated and will be removed in Python 3.9
3 participants
@tirkarthi @kevin-bates @minrk