-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Read binary files in chunks #536
Conversation
Well, almost works, the files are corrupted, I'll try again tomorrow... |
This solves the upload portion, but not the download back to the server portion. We need to support a similar chunked protocol on the XHR end. |
When we |
A similar protocol would be needed for |
@blink1073 do you think this is stable enough to consider for 4.1? |
Verbally "no" so marking as 4.2 |
This is an important feature for me. I'm using the upload for an online demo to convert data files to a standard format. If there is something I can do to help to speed up the inclusion of this feature I'd be glad to help. |
I think the simplest way would be to add an optional |
Is it worth looking for existing solutions? Uploading a large file over HTTP isn't that unusual, is it? |
From what I've gathered in searching, the consensus is to use the HTML5 FileReader API using binary chunks. There are uploader libraries that handle the chunking/resuming, but we also need to stream downloads from the server. Either way, we'd have to implement the logic on the server to handle streaming. |
That has gone stale, I'm going to close to keep the active PR queue short, and tag with "Closed PR" so that we can reopen when needed. Thanks a lot @blink1073 for getting that started . |
Fixes #96.
I verified this works with a 340MB file (that crashed in the previous version), and also still works with
.ipynb
files.