Embed frontend_config toctree in config_overview #5742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The section `Notebook front-end client` in the config overview page was essentially a toc tree except the sub-section links went to the top of the frontend_config page rather than the real sub-sections in that page because they all used the same reference. Rather than create a unique reference for each sub-section in the frontend_config page, this simply embeds the frontend_config toctree within the config_overview page which essentially has the same effect. Closes jupyter#5740
kevin-bates
approved these changes
Sep 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The section
Notebook front-end clientin the config overviewpage was essentially a toc tree except the sub-section links
went to the top of the frontend_config page rather than the real
sub-sections in that page because they all used the same reference.
Rather than create a unique reference for each sub-section in the
frontend_config page, this simply embeds the frontend_config toctree
within the config_overview page which essentially has the same effect.
Closes #5740