Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject session identifier into environment variable. #6279

Closed
wants to merge 1 commit into from
+7 −3
Closed

Inject session identifier into environment variable. #6279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions notebook/services/sessions/sessionmanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
from tornado import gen, web

from traitlets.config.configurable import LoggingConfigurable
from ipython_genutils.py3compat import unicode_type
from traitlets import Instance

from notebook.utils import maybe_future
Expand Down Expand Up @@ -86,7 +85,7 @@ def session_exists(self, path):

def new_session_id(self):
"Create a uuid for a new session"
return unicode_type(uuid.uuid4())
return str(uuid.uuid4())

@gen.coroutine
def create_session(self, path=None, name=None, type=None, kernel_name=None, kernel_id=None):
Expand All @@ -107,8 +106,13 @@ def start_kernel_for_session(self, session_id, path, name, type, kernel_name):
"""Start a new kernel for a given session."""
# allow contents manager to specify kernels cwd
kernel_path = self.contents_manager.get_kernel_path(path=path)

kernel_id = yield maybe_future(
self.kernel_manager.start_kernel(path=kernel_path, kernel_name=kernel_name)
self.kernel_manager.start_kernel(
path=kernel_path,
kernel_name=kernel_name,
env={"JPY_SESSION_NAME": path},
)
)
# py2-compat
raise gen.Return(kernel_id)
Expand Down