Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure custom preload is correctly handled #6580

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

echarles
Copy link
Member

Follow-up of jupyter/nbclassic#155

The custom preload needs to be handled in page.html and build-main.js.

We also bump and pin to nbclassic==0.4.6.

@echarles echarles changed the base branch from main to 6.5.x October 16, 2022 09:41
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch datalayer-externals/jupyter-notebook/fix/custom-preload

@echarles echarles added the bug label Oct 16, 2022
@echarles
Copy link
Member Author

close/reopen to kick CI

@echarles echarles closed this Oct 16, 2022
@echarles echarles reopened this Oct 16, 2022
@RRosio
Copy link
Collaborator

RRosio commented Oct 18, 2022

LGTM, thank you @echarles!

@RRosio RRosio merged commit 2a9199d into jupyter:6.5.x Oct 18, 2022
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Oct 28, 2022
https://build.opensuse.org/request/show/1031574
by user bnavigator + dimstar_suse
- Add notebook-pr6578+pr6580-404errors.patch
  * fix 404 errors at startup
  * gh#jupyter/notebook#6580 -- custom preload
  * gh#jupyter/notebook#6578 -- jquery from nbclassic
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants