Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a banner and log to information about the migration to Notebook 7 plan #6742

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

echarles
Copy link
Member

Contribues to jupyter/nbclassic#214

@echarles echarles changed the base branch from main to 6.5.x February 20, 2023 07:20
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch datalayer-externals/jupyter-notebook/feat/banner_log

@echarles
Copy link
Member Author

Closing/reopening to trigger CI

@echarles echarles closed this Feb 20, 2023
@echarles echarles reopened this Feb 20, 2023
@RRosio
Copy link
Collaborator

RRosio commented Feb 20, 2023

LGTM, Thank you @echarles!

@RRosio RRosio merged commit d0ecb74 into jupyter:6.5.x Feb 20, 2023
@echarles
Copy link
Member Author

Thx @RRosio for the review and merge.

@moschlar
Copy link

Is there a way to prevent rendering this notice in the web page as a server administrator?

I'm running a JupyterHub and don't want user to be (yet) disturbed by the notice.

@echarles
Copy link
Member Author

Is there a way to prevent rendering this notice in the web page as a server administrator?

There is not such thing today. Could you open a dedicated issue for that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants