Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default windowingMode to none or defer #6855

Closed
wants to merge 2 commits into from

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 28, 2023

Before

Keeping the default setting to full adds a few glitches as mentioned in jupyterlab/jupyterlab#13343 and in the following screencast:

windowing-full.mp4

After

Switching to none seems to be fixing most of these issues:

windowing-none.mp4
  • Switch windowingMode to none by default
  • Document how to switch to full or defer (maybe just a link to the JupyterLab docs)

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/disable-windowing

@jtpio jtpio added this to the 7.0 milestone Apr 28, 2023
@jtpio
Copy link
Member Author

jtpio commented Apr 28, 2023

It could also be interesting to try defer first.

@jtpio jtpio changed the title Default windowingMode to none Default windowingMode to none or defer Apr 28, 2023
@jtpio
Copy link
Member Author

jtpio commented May 2, 2023

defer seems to be a good compromise:

defer-windowing.mp4

@jtpio
Copy link
Member Author

jtpio commented May 4, 2023

This can likely be closed in favor of jupyterlab/jupyterlab#14490

@jtpio
Copy link
Member Author

jtpio commented May 9, 2023

Closing as fixed by jupyterlab/jupyterlab#14490.

Will need to update to a newer version of JupyterLab to grab the fix.

@jtpio jtpio closed this May 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant