[WIP] PR: Changes for handling Shortcuts with traitlets in consoleWidget #621
Conversation
jsbautista
changed the title
There was a problem hiding this comment.
Thank @jsbautista for your work here! Added some suggestions that should prevent the changes here to cause a segfault. If you have any question about the suggested changes let me know!
Co-authored-by: Daniel Althviz Moré <16781833+dalthviz@users.noreply.github.com>
There was a problem hiding this comment.
Thanks for the latest changes @jsbautista ! Left some new comments/suggestions related with the method that gathers the different actions with shortcuts over a dictionary. Also, it could be nice to add a GIF or a command/flag/config file over the PR description to show an example of how changing the shortcuts could be done using the work being done here.
qtconsole/util.py
Outdated
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| from qtpy import QtCore, QtGui | |||
|
|
|||
| from traitlets import HasTraits, TraitType | |||
| from traitlets import default, HasTraits, TraitType, Unicode, observe | |||
There was a problem hiding this comment.
Could it be that these added imports are not needed anymore?
qtconsole/qtconsoleapp.py
Outdated
| self.window_shortcuts['shortcut_new_kernel_tab'] = self.shortcut_new_kernel_tab | ||
| self.window_shortcuts['shortcut_slave_kernel_tab'] = self.shortcut_slave_kernel_tab | ||
| self.window_shortcuts['shortcut_existing_kernel_tab'] = self.shortcut_existing_kernel_tab | ||
| self.window_shortcuts['shortcut_close'] = self.shortcut_close | ||
| self.window_shortcuts['shortcut_save'] = self.shortcut_save | ||
| self.window_shortcuts['shortcut_print'] = self.shortcut_print | ||
| self.window_shortcuts['shortcut_quit'] = self.shortcut_quit | ||
| self.window_shortcuts['shortcut_undo'] = self.shortcut_undo | ||
| self.window_shortcuts['shortcut_redo'] = self.shortcut_redo | ||
| self.window_shortcuts['shortcut_cut'] = self.shortcut_cut | ||
| self.window_shortcuts['shortcut_copy'] = self.shortcut_copy | ||
| self.window_shortcuts['shortcut_copy_raw'] = self.shortcut_copy_raw | ||
| self.window_shortcuts['shortcut_paste'] = self.shortcut_paste | ||
| self.window_shortcuts['shortcut_select_all'] = self.shortcut_select_all | ||
| self.window_shortcuts['shortcut_ctrl_shift_m'] = self.shortcut_ctrl_shift_m | ||
| self.window_shortcuts['shortcut_full_screen'] = self.shortcut_full_screen | ||
| self.window_shortcuts['shortcut_zoom_in'] = self.shortcut_zoom_in | ||
| self.window_shortcuts['shortcut_zoom_out'] = self.shortcut_zoom_out | ||
| self.window_shortcuts['shortcut_reset_font_size'] = self.shortcut_reset_font_size | ||
| self.window_shortcuts['shortcut_clear'] = self.shortcut_clear | ||
| self.window_shortcuts['shortcut_interrupt_kernel'] = self.shortcut_interrupt_kernel | ||
| self.window_shortcuts['shortcut_restart_kernel'] = self.shortcut_restart_kernel | ||
| self.window_shortcuts['shortcut_minimize'] = self.shortcut_minimize | ||
| self.window_shortcuts['shortcut_prev_tab'] = self.shortcut_prev_tab | ||
| self.window_shortcuts['shortcut_next_tab'] = self.shortcut_next_tab | ||
| self.window_shortcuts['shortcut_rename_window'] = self.shortcut_rename_window | ||
| self.window_shortcuts['shortcut_rename_current_tab'] = self.shortcut_rename_current_tab |
There was a problem hiding this comment.
We could also make this method return a dict instead of initializing a class attribute. So maybe calling the method something like _get_shortcuts and doing something like:
shortcuts = {
'shortcut_new_kernel_tab': self.shortcut_new_kernel_tab,
'shortcut_slave_kernel_tab': self.shortcut_slave_kernel_tab,
...
}
return shortcuts
qtconsole/qtconsoleapp.py
Outdated
| self.initialize_window_shortcuts() | ||
| self.window = MainWindow(self.app, shortcuts=self.window_shortcuts, |
There was a problem hiding this comment.
Maybe instead of defining an attribute we could make the initialize_window_shortcuts to just be a utility method that returns a dict with the shortcuts and we call it here. So something like:
| self.initialize_window_shortcuts() | |
| self.window = MainWindow(self.app, shortcuts=self.window_shortcuts, | |
| self.window = MainWindow(self.app, shortcuts=self._get_shortcuts(), |
qtconsole/qtconsoleapp.py
Outdated
| #-------------------------------------------------------------------------- | ||
| # Shortcuts definition | ||
| #-------------------------------------------------------------------------- | ||
| window_shortcuts={} |
There was a problem hiding this comment.
With the idea of making the method return the dict with the shortcuts this would not be needed anymore
qtconsole/qtconsoleapp.py
Outdated
| # Shortcuts definition | ||
| #-------------------------------------------------------------------------- | ||
| window_shortcuts={} | ||
| shortcut_new_kernel_tab = Unicode('Ctrl+T').tag(config=True) |
There was a problem hiding this comment.
Checking how other traitlets variables are being defined around, seems like we could also write this like:
... = Unicode('Ctrl+T', config=True)We could even write some help strings for these new variables. So something like:
... = Unicode('Ctrl+T', config=True, help="Shortcut to create a new kernel tab")
No description provided.