This repository was archived by the owner on Aug 30, 2022. It is now read-only.
[WIP] Use the new session api #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The updated integration tests pass (against notebook master, if I comment out the existing session tests that haven't been updated yet). |
minrk
reviewed
Oct 7, 2016
| if (this.isDisposed) { | ||
| return Promise.reject(new Error('Session is disposed')); | ||
| } | ||
| let data = JSON.stringify({ type }); |
There was a problem hiding this comment.
I did not know that you could use this shorthand for objects!
There was a problem hiding this comment.
Yep, available in ES6. I am going to also verify that current master of services still works against notebook master (that the old api still works).
|
Tests pass on services master and notebook master: |
|
Very nice. |
|
Closing as stale. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #236
cc @minrk