Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for terminating the terminals #142

Merged
merged 21 commits into from
Mar 3, 2022

Conversation

blink1073
Copy link
Contributor

No description provided.

@blink1073
Copy link
Contributor Author

Heads up @andfoy, it looks like we're not able to properly terminate terminals anymore in pywinpty 2.0+.

 >       assert self.single_tm.terminal.ptyproc.closed
E       assert False

https://github.com/blink1073/terminado/runs/5162491817?check_suite_focus=true

The terminate function is returning True, as asserted in the test, but the ptyproc is not closing, and not triggering EOF.

I'll try and do some more debugging next week.

@andfoy
Copy link
Member

andfoy commented Feb 11, 2022

Thanks for the ping, please let me know if I can help in any way

@andfoy
Copy link
Member

andfoy commented Mar 2, 2022

@blink1073, I've just released pywinpty v2.0.3, it should be available in a few minutes

@blink1073 blink1073 closed this Mar 2, 2022
@blink1073 blink1073 reopened this Mar 2, 2022
@blink1073
Copy link
Contributor Author

I've just released pywinpty v2.0.3, it should be available in a few minutes

Thanks!

@blink1073
Copy link
Contributor Author

@andfoy it works now when I specify using the WinPTY backend!

@blink1073 blink1073 merged commit 9db9300 into jupyter:main Mar 3, 2022
@blink1073 blink1073 deleted the test-terminate branch March 3, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants