Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo opencascade positioning and rotation #580

Merged
merged 41 commits into from
Nov 28, 2024
Merged

Undo opencascade positioning and rotation #580

merged 41 commits into from
Nov 28, 2024

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Nov 18, 2024 •
edited by martinRenou
Loading

Also fix #590

On main:
image

On this branch:
image

@arjxn-py arjxn-py changed the title Undo opencascade positioning and rotation [WIP] Undo opencascade positioning and rotation Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

Preview PR at appsharing.space

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

Integration tests report: appsharing.space

@arjxn-py arjxn-py mentioned this pull request Nov 19, 2024
Merged
@martinRenou
Copy link
Member

Just rebased from the UI

@arjxn-py
Copy link
Member Author

Only exploded view is broken now

@arjxn-py arjxn-py changed the title [WIP] Undo opencascade positioning and rotation Undo opencascade positioning and rotation Nov 19, 2024
martinRenou
martinRenou requested changes Nov 19, 2024
View reviewed changes
packages/base/src/3dview/helpers.ts Show resolved Hide resolved
packages/base/src/3dview/mainview.tsx Show resolved Hide resolved
packages/base/src/3dview/mainview.tsx Outdated Show resolved Hide resolved
packages/base/src/3dview/mainview.tsx Outdated Show resolved Hide resolved
@arjxn-py arjxn-py mentioned this pull request Nov 20, 2024
Merged
arjxn-py and others added 2 commits November 27, 2024 20:39
@arjxn-py @martinRenou
Update packages/base/src/3dview/mainview.tsx
d23b9b5 
Co-authored-by: martinRenou <martin.renou@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
dc2e203 
for more information, see https://pre-commit.ci
@martinRenou
Copy link
Member

It is starting to look correct!

The UI-tests failure looks legit.

First issue:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'Position') when trying to open the step file and stl file examples. We need to default the placement somewhere in the code

Second issue:

The Cone of test.jcad looks broken if we rotate it a bit more. This may have to do with rotation of vertices.

Screencast.From.2024-11-27.16-27-47.mp4

martinRenou
martinRenou requested changes Nov 28, 2024
View reviewed changes
packages/base/src/3dview/helpers.ts Outdated Show resolved Hide resolved
martinRenou
martinRenou requested changes Nov 28, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More nitpicky comments 😆

packages/base/src/3dview/helpers.ts Outdated Show resolved Hide resolved
packages/base/src/3dview/helpers.ts Outdated Show resolved Hide resolved
packages/base/src/3dview/mainview.tsx Outdated Show resolved Hide resolved
@arjxn-py
Copy link
Member Author

Please update snapshots 🌮

@martinRenou
Copy link
Member

bot please update snapshots!

martinRenou
martinRenou approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯 💯

@martinRenou martinRenou merged commit 8ea5fc8 into jupytercad:main Nov 28, 2024
1 of 2 checks passed
@arjxn-py arjxn-py deleted the recentering branch December 1, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transform Controls not disabled by default
2 participants
@arjxn-py @martinRenou