Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure to use autoclass on non-traitlets configurable classes #10

Merged
merged 1 commit into from
Dec 6, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions autodoc_traits/autodoc_traits.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""autodoc extension for configurable traits"""
from sphinx.ext.autodoc import AttributeDocumenter
from sphinx.ext.autodoc import ClassDocumenter
from traitlets import MetaHasTraits
from traitlets import TraitType
from traitlets import Undefined

Expand All @@ -14,6 +15,8 @@ class ConfigurableDocumenter(ClassDocumenter):
def get_object_members(self, want_all):
"""Add traits with .tag(config=True) to members list"""
check, members = super().get_object_members(want_all)
if not isinstance(self.object, MetaHasTraits):
return check, members
get_traits = (
self.object.class_own_traits
if self.options.inherited_members
Expand Down