Bound traitlets<5.10 and add test for issue observed in newer versions
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've obseved that Dict, List, Instance, and Command trait types no longer gets their help strings set with traitlets 5.10.0 but this wasn't an issue in traitlets 5.9.0.
consideRatio
changed the title
|
Could we put an upper bound on traitlets in Line 23 in 5632a2a And remove it when there's a fix? |
|
Great idea @manics, done! |
consideRatio
changed the title
traitlets<5.10 and add test to catch issue observed in newer versions
consideRatio
changed the title
traitlets<5.10 and add test to catch issue observed in newer versionstraitlets<5.10 and add test for issue observed in newer versions
|
@manics OK to go for a patch release with this? |
|
A release sounds good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've obseved that Dict, List, Instance, and Command trait types no longer gets their help strings set with traitlets 5.10.0 but this wasn't an issue in traitlets 5.9.0. I've now tracked this down to work all the way up to ipython/traitlets#818 was merged.
Introducing this causes tests to fail, but they should fail because we have an issue right now. This has been observed in:
latestdocs is missing some traitlets help kubespawner#788