Skip to content

Commit

Permalink
Merge pull request #1592 from manics/build_docker_config-helm-not-bin…
Browse files Browse the repository at this point in the history
…derhub

Warn about build_docker_config being a Helm Chart option not a BinderHub option
  • Loading branch information
consideRatio authored Dec 17, 2022
2 parents 2ba938b + 0f65f33 commit 8351995
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions binderhub/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,10 @@ def docker_build_host_validate(self, proposal):
have an effect, as the push_secrets will overwrite
.docker/config.json
In this case, make sure that you include your config in your push_secret
WARNING: The value of this parameter is managed by the binderHub Helm Chart.
It is not managed by the BinderHub application itself.
If you are running BinderHub in another way this parameter has no effect.
""",
config=True,
)
Expand Down

0 comments on commit 8351995

Please sign in to comment.