Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventsource continues launching more containers if left open #317

Open
rgbkrk opened this issue Nov 29, 2017 · 4 comments
Open

eventsource continues launching more containers if left open #317

rgbkrk opened this issue Nov 29, 2017 · 4 comments

Comments

@rgbkrk
Copy link
Member

rgbkrk commented Nov 29, 2017 •
edited
Loading

If you leave the eventsource open after "ready" it continues launching more

Reproduction steps:

  • Visit about:blank
  • Open DevTools Console
  • Paste:
es = new window.EventSource('https://mybinder.org/build/gh/nteract/vdom/master')
es.onmessage = msg => console.log(msg)
  • wait...
  • watch all the successive launches

Not a crazy deal for me, I just happened to notice while hitting the event source API directly. My current code does a .close appropriately. Figured this should probably be cleaned up though.
@yuvipanda yuvipanda mentioned this issue Dec 17, 2017
Open
@betatim betatim mentioned this issue Feb 8, 2018
Closed
SamLau95 added a commit to SamLau95/nbinteract that referenced this issue Feb 9, 2018
@SamLau95
Ensure EventSource is closed if connection fails
5cb1502 
jupyterhub/binderhub#317 points out that an
EventSource will repeatedly launch servers if it isn't closed properly.
Although we close the EventSource after the server launches
successfully, I noticed that the EventSource makes repeated requests if
the server fails to launch.

To test this, I opened a page that uses `nbinteract` to start a
currently banned image (`SamLau95/nbinteract-image`). In the console
logs, I saw the EventSource endlessly attempting to start a Binder
server and verified that the page made multiple requests in the Network
tab of the dev tools.

To fix this, I enforce a maximum number of failed connection attempts
and close the EventSource if it fails to connect after three tries.

To test this, I opened the same page as above and verified that the page
only makes three attempts to connect before logging an error message and
stopping.

This should help with #34, although I'm not sure if this was the reason
for the Binder overload.
@SamLau95 SamLau95 mentioned this issue Feb 9, 2018
Merged
@choldgraf
Copy link
Member

I think we just got burned by this with the nbinteract repository. @rgbkrk did you figure out a way to work around this from your side of things?

@rgbkrk
Copy link
Member Author

rgbkrk commented Apr 17, 2018 •
edited
Loading

Yeah, we .close() the event source after we get a freshly baked container. It wasn't an issue at the time, it just smelled like a likely operational problem waiting to happen.

@choldgraf
Copy link
Member

it just smelled like a likely operational problem waiting to happen.

@SamLau95 SamLau95 mentioned this issue May 21, 2018
Closed
@manics
Copy link
Member

manics commented Sep 20, 2021

Is this still a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rgbkrk @manics @choldgraf