Allow copying build logs easily

[yuvipanda]

The terminal can be fickle to copy build logs from. We should allow people to download them.

[choldgraf]

@yuvipanda do the build logs still exist on the page even though they're no longer visible within the xterm window? Now that we're using the web clipper package could we just create a "copy logs" button?

[yuvipanda]

They do, and you should be able to make a copy logs button! It might be slightly tricky, since xterm.js only keeps some amount of scrollback, but would be not too difficult to add I think.

…

On Fri, Jan 12, 2018 at 12:47 PM, Chris Holdgraf ***@***.***> wrote: @yuvipanda <https://github.com/yuvipanda> do the build logs still exist on the page even though they're no longer visible within the xterm window? Now that we're using the web clipper package could we just create a "copy logs" button? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#75 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB23mMB3kD9pQwJ2srasKEtfAhYjNzeks5tJ8E3gaJpZM4OaQgk> .

-- Yuvi Panda T http://yuvi.in/blog

[choldgraf]

Would another option be to do this outside of xterm entirely? Basically any time some new data is written we can append that to a hidden div or something, and then copy/paste just copies from that div?

[yuvipanda]

Yes, but we've to be cautious about memory usage. We can easily crash a user's browser (at least our tab) that way.

…

On Sat, Jan 13, 2018 at 4:12 PM, Chris Holdgraf ***@***.***> wrote: Would another option be to do this outside of xterm entirely? Basically any time some new data is written we can append that to a hidden div or something, and then copy/paste just copies from that div? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#75 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB23jKELnI_XScipDNuGaDMPUy_a-RMks5tKUZugaJpZM4OaQgk> .

-- Yuvi Panda T http://yuvi.in/blog

[kannes]

Something I noticed:

If I do not uncollapse the log viewer right after loading the URL (and instead let Binder do its thing and uncollapse the viewer itself at the end), neither Firefox nor Chromium let me select any text in it.

Firefox does not let me copy the text at all.

Chromium requires me to right-click -> "Copy". Neither Ctrl-C nor Linux' usual select-to-copy copying work.

[choldgraf]

Arg - thanks for your input @kannes!! We agree this is a pretty frustrating piece of the Binder UX right now :-/ if we can store the text in an element somewhere on the page, it should be pretty easy to use clipboard.js to give a "copy" button, but we need to make sure not to accidentally crash something in the process

[manics]

Done in #1335

[kannes]

Thank you!