-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Software Heritage provider #1256
base: main
Are you sure you want to change the base?
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
66e4681
to
1e584b3
Compare
Pushed an updated version:
|
ping |
Sorry @douardda , it's the usual problem of a lack of time 😞 |
No pb, at least it's not some code related problem :-) |
I've updated the PR to fix the conflicts, if the tests are OK I would greatly appreciate someone to merge it. |
humm no idea why the doc building job is failing here, is it related to my changes or is there a (transient) problem with the job? |
It's due to #1308. Although it's fixed in |
Software Heritage¹ is a non-profit multi-stakeholder initiative which collects, preserves and shares all software that is publicly available in source code form. It provides a public API allowing to retrieve any piece of source code that has been ingested and is identified via its SWHID², including a growing number of jupyter notbooks. Thanks to the recent support for SWHID added in repo2docker, this now bring support to SWHID to binderhub as a Provider. ¹ https://www.softwareheritage.org ² https://docs.softwareheritage.org/devel/swh-model/persistent-identifiers.html#persistent-identifiers
thanks @manics, I've rebased my PR on current master, let's see how it goes |
There is a failure, but it's a dataverse related one:
probably a transient network failure of doi.org. Do I need to spawn the job again? |
I've rerun the CI jobs and it's green 💚 |
Thanks @manics |
@betatim (gentle) ping? |
I've just tried with using a UI only config and hit this error:
|
This is also missing a |
This comment was marked as off-topic.
This comment was marked as off-topic.
@manics ok, I will try to rebase it ASAP so maybe it can be merged before (?) that. Thanks |
If you can add fixes for my comments I'll review and merge if possible. FYI there's a (still in development) way to run BinderHub locally with just Docker, this might help you check the BinderHub UI |
Software Heritage¹ is a non-profit multi-stakeholder initiative which collects,
preserves and shares all software that is publicly available in source code
form.
It provides a public API allowing to retrieve any piece of source code
that has been ingested and is identified via its SWHID², including a
growing number of jupyter notbooks.
Thanks to the recent support for SWHID added in repo2docker, this now
bring support to SWHID to binderhub as a Provider.
¹ https://www.softwareheritage.org
² https://docs.softwareheritage.org/devel/swh-model/persistent-identifiers.html#persistent-identifiers
Note: I am not sure I did everything fine in the PR, and I have tested it (I have no minikube or k3s setup on my machine for now), so comments/criticisms very welcome!