docker registry: handle subdirectories in custom registries #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed image name splitting in manifest for this case "dockerhub.ebi.ac.uk/bioimagearchive/k8s-jupyterhub/binder-ebibiostudies-2dbiostudies-2dnotebooks-c728a8:7f8fe051826f19933283b7a4dfe975b62a1e17ba" Tested on: "registry.hub.docker.com/nvidia/cuda:11.2.1-devel-ubuntu20.04"
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
minrk
changed the title
|
Congrats on your first merged pull request in this project! 🎉 |
|
Thanks! |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Mar 25, 2021
jupyterhub/binderhub#1269 Merge pull request #1269 from ctr26/patch-1
|
I should note that this PR solves this problem better and more completely than mine: |
This was referenced Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed image name splitting in manifest for this case:
"dockerhub.ebi.ac.uk/bioimagearchive/k8s-jupyterhub/binder-ebibiostudies-2dbiostudies-2dnotebooks-c728a8:7f8fe051826f19933283b7a4dfe975b62a1e17ba"
Tested on:
"registry.hub.docker.com/nvidia/cuda:11.2.1-devel-ubuntu20.04"
Background:
Binderhub can pull my images and push them to our gitlab docker registry, but it can't find manifest files, I think this patch fixes this and doesn't break every other container repo
closes #1267