Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: let prettier format .js files #1769

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Oct 9, 2023

A one line change in pre-commit-config -> autoformatting made by pre-commit.ci.

@consideRatio consideRatio added maintenance Under the hood improvements and fixes code:html/js/css html/js/css changes. code:js-binderhub-client js changes to binderhub-client labels Oct 9, 2023
@yuvipanda
Copy link
Collaborator

Yep, let's wait for the one I currently have brewing and then we can merge this. Will definitely help me avoid merge conflicts.

Thanks @consideRatio

@consideRatio consideRatio changed the title pre-commit: let prettier format javascript pre-commit: let prettier format .js files Oct 9, 2023
@consideRatio
Copy link
Member Author

consideRatio commented Oct 9, 2023

let's wait for the one I currently have brewing and then we can merge this

This was #1771 that is now merged I think. EDIT: or #1742 ?

@yuvipanda
Copy link
Collaborator

@consideRatio nope, there's one more coming (#1771 was a part of it).

@yuvipanda yuvipanda merged commit 3fe49aa into jupyterhub:main Oct 9, 2023
11 of 13 checks passed
@yuvipanda
Copy link
Collaborator

Actually let's just do this, I can rebase. Thanks @consideRatio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code:html/js/css html/js/css changes. code:js-binderhub-client js changes to binderhub-client maintenance Under the hood improvements and fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants