[MRG] Generate coverage while running tests #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betatim
changed the title
|
At least inn the codecov pages linked from this PR it seems like we get the big green dots in front of each line back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this inconsistency between how we run our tests while investigating why codecov doesn't show me which lines have coverage and which don't.
I was expecting https://codecov.io/gh/jupyterhub/binderhub/src/master/binderhub/build.py to show me which lines are covered. We seem to be computing some kind of coverage number because for the whole file it knows, but for some reason it doesn't show which lines are missing. If you look at code from (say) repo2docker https://codecov.io/gh/jupyter/repo2docker/src/master/repo2docker/app.py you see the green blobs in front of lines that are covered as well as background shading.