[MRG] Add a /health endpoint to BinderHub #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another question: what status code should this return when something is not working but we still want to send the JSON body (so that the requester can see what is broken)? I'd suggest 503 but that is nothing more than a hunch. |
betatim
commented
Jul 26, 2019
betatim
changed the title
|
Ready for some review. I don't know a good way to test the docker registry part :-/ Planning on testing that once it is deployed. |
willingc
approved these changes
Jul 30, 2019
|
I'll merge it now. I think there are bound to be a few snags but I can't find any more right now -> needs some real world traffic/usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reports the health of BinderHub and the services it needs to run.
It is quite primitive but maybe good enough to get going? In particular the request to
/healthwill take a long time if we have to retry connections to the hub or the registry. A smarter way would be to monitor those independently of someone calling the end point and having the most recent results available. Not quite sure what the best way to do that would be (where would the results be stored so they are "globally available"?)