updating social tweaks #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged because it is tricky to imagine how it will look and easy to see if we deploy it. I don't know enough about cards and FB. Is it possible to define several "cards" and each page (FB, twitter, etc) will use the "last one it understands"? |
|
Should we copy what GitHub does? This is a screenshot of the
they seem to define one image for twitter and then again using the opengraph method. Maybe that is how you get different sized images for twitter (small/compact) and FB (large)? |
yuvipanda
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Aug 3, 2019
|
I do think we can define a twitter-specific image...that should be pretty straightforward. Shall we make that a PR? |
|
(fyi it'll be later today or tomorrow for me to implement this, I'm in seattle!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a couple things for the social images:
mybinder.organd that's it, you'll see the big logoCurious what @betatim thinks about it - we can iterate a bit, this is just a first pass