Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add more loading messages #924

Merged
merged 2 commits into from
Aug 11, 2019
Merged

Conversation

betatim
Copy link
Member

@betatim betatim commented Aug 11, 2019

Adds a few more "waiting for launch" messages.

I tried to add a full stop at the end of each message as I think it looks weird to not end a sentence

cc @choldgraf

@choldgraf
Copy link
Member

lgtm other than that closed link tag. thanks! i wonder if at some point we should add fun ones in there...

@choldgraf
Copy link
Member

for some reason github says I dont have push permissions on the inline commit, so once you add it, then Ill merge

Co-Authored-By: Chris Holdgraf <choldgraf@gmail.com>
@betatim
Copy link
Member Author

betatim commented Aug 11, 2019

for some reason github says I dont have push permissions on the inline commit, so once you add it, then Ill merge

Thanks for spotting this! The same happens to me as well with suggestions and not being allowed to commit them. But not on all and every repo so I haven't yet been able to work out what we are doing wrong. My guess was that this happens when the "Allow edits from maintainers" box wasn't ticked but for this PR it is ticked ... so I am fresh outta ideas :-/

@choldgraf choldgraf merged commit f565958 into jupyterhub:master Aug 11, 2019
yuvipanda pushed a commit to jupyterhub/helm-chart that referenced this pull request Aug 11, 2019
@betatim betatim deleted the message-tweaks branch August 12, 2019 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants