Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Fix docker registry health check #932

Merged
merged 3 commits into from
Aug 16, 2019
Merged

[MRG] Fix docker registry health check #932

merged 3 commits into from
Aug 16, 2019

Conversation

betatim
Copy link
Member

@betatim betatim commented Aug 16, 2019

The image name being passed was wrong and the check didn't return True when it succeeded.

Also added a throttle so that we only check every 15s

@betatim betatim changed the title Fix docker registry health check [MRG] Fix docker registry health check Aug 16, 2019
choldgraf
choldgraf approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits and I'm +1 to merge if you are! Feel free to do once you minor changes are resolved

binderhub/health.py Outdated Show resolved Hide resolved
binderhub/health.py Outdated Show resolved Hide resolved
betatim and others added 2 commits August 16, 2019 22:13
@betatim @choldgraf
Fix log message typo
7378f71 
Co-Authored-By: Chris Holdgraf <choldgraf@gmail.com>
@betatim @choldgraf
Fix registry check interval
9b47b7b 
Co-Authored-By: Chris Holdgraf <choldgraf@gmail.com>
@betatim betatim merged commit eb1fc66 into jupyterhub:master Aug 16, 2019
@betatim betatim deleted the improve-registry-health-again branch August 16, 2019 20:13
@betatim
Copy link
Member Author

betatim commented Aug 16, 2019

Thanks for catching those. Merged and will deploy it once its built.

yuvipanda pushed a commit to jupyterhub/helm-chart that referenced this pull request Aug 16, 2019
[binderhub] Automatic update for commit eb1fc66
fbd9945 
jupyterhub/binderhub#932
@pangeo-bot pangeo-bot mentioned this pull request Aug 23, 2019
Merged
@choldgraf choldgraf added the bug label Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@betatim @choldgraf