normalize username to lock password #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've confirmed that this critical security fix works. Thank you @georgejhunt for these very important patches to firstuseauthenticator! Related: |
allows for following normalization changes
minrk
changed the title
|
Congrats on your first merged pull request in this project! 🎉 |
|
Thanks! I've updated this to call the |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent username with changed capitalization from taking over an existing username/password combination.
Root cause: jupyterhub lower-cases username, but firstuseauthenticator does not. So alternate capitalization of username gains access to, and creates a parallel path to user files (multiple capitalizations of username have access)