Skip to content

Make 'dashboard-dir' an optional argument #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2021
Merged

Make 'dashboard-dir' an optional argument #28

merged 1 commit into from
Jul 20, 2021

Conversation

yuvipanda
Copy link
Collaborator

Most likely it will always be 'dashboards/'

@yuvipanda
Make 'dashboard-dir' an optional argument
202fd90 
Most likely it will always be 'dashboards/'
@yuvipanda yuvipanda requested review from consideRatio and minrk July 20, 2021 10:45
consideRatio
consideRatio approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I note that this is not yet being packaged into a PyPI package or similar, so +1 for accepting a breaking change.

@yuvipanda yuvipanda merged commit 775a09f into jupyterhub:main Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

@minrk minrk Awaiting requested review from minrk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvipanda @consideRatio