scheduler_name - Complementary pr to #190 #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@minrk could I get a quick look from you on this? It would be great to get this merged for my ability to test and develop #205, which is required by jupyterhub/zero-to-jupyterhub-k8s#758 |
|
Closed in favor for #205 where the commits now resides. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #190 I only added support in the make_pod function to create pods with the
spec.schedulerNamefield set, but this is pointless without having a traitlet to configure what it should be in the spawner. This is added in this PR.I also added a note on what I often need to do in order to get my tests to run, but I don't get whats going on really, but I figure it is something that is cached and needs to be rebuilt within
.eggs.