Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #756 and #757 -
other_text
option insideunlisted_choice
which allows user to specify a custom text in the select drop-downI might have underestimated the complexity in hiding the select dropdown if there are no
choices
present, and that bit seems to have gotten a bit ugly. Will leave some comments in the code to see if there's things we can improve.@yuvipanda @consideRatio @GeorgianaElena - firstly, thank you so much for fixing up issues with the
unlisted_choices
work, and many apologies for the delay in getting to these fixes. I am not super happy with the implementation in this PR, and I'll leave some more notes with the code. I did a bit of testing though, and it seems to me like it all works as expected.If this approach seems ok to you all, I think what might be pending:
choices
but have anunlisted_choice
to make testing easierchoices
to make sure the backend handling is covered with tests.