Exchanging ldap3 constants in if/else

[1kastner]

They were just the wrong way round and no error has popped up so far, see the ldap3 author's statements at cannatag/ldap3#855

[1kastner]

@manics I hope everything is solved. I believe use_ssl means either SSL or STARTTLS is used, right? Unencrypted communication is not supported at all, is it?

[1kastner]

PS: For me the solution is working in application and the tests pass, I don't know how many more test cases are needed here.

[manics]

Thanks for fixing this! The fix makes sense to me

@dhirschfeld would you mind giving a 👍 since you're more familiar with the code? Thanks!

[dhirschfeld]

LGTM

[dhirschfeld]

I haven't looked at this code in a long time but the description in the linked issue seems pretty clear.

[1kastner]

A small question @manics, how will things continue from here? How does the versioning work?

According to what I see at https://github.com/jupyterhub/ldapauthenticator the pypi version is at 1.3.1 (including my quick fix from #172), the conda version at 1.3.0 (without the fix, so I guess it should break if you install it freshly), and the last github release is from 1.2.2 (so completely out of date, see https://github.com/jupyterhub/ldapauthenticator/releases).

This new proper fix now is on the dev branch for the new version 1.3.2. When might the version 1.3.2 be released? And through which channels? Thank you very much!

[manics]

I've just tagged 1.3.2 so it should be on pypi soon.

In general conda-forge packages are maintained independently of the Python/Pypi package: https://github.com/conda-forge/jupyterhub-ldapauthenticator-feedstock

Though in this case some of the maintainers overlap

[1kastner]

@manics so the github releases (see https://github.com/jupyterhub/ldapauthenticator/releases ) are not used anymore?

[dhirschfeld]

GitHub "releases" are just some UI sugar on top of an ordinary git tag and don't add anything required for packaging. By default conda-forge builds from the pypi sources.

All the tags can be seen in the tags view: https://github.com/jupyterhub/ldapauthenticator/tags

[1kastner]

Thank you very much for that information!