Set template config correctly #3217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out just setting it on NotebookApp doesn't set it on ServerApp now, and so all of our templates were actually just no-ops for a while. Discovered while testing jupyterhub#3178
minrk
reviewed
Feb 12, 2025
| @@ -42,7 +42,7 @@ tags: {} | |||
|
|
|||
| etcJupyter: | |||
| jupyter_notebook_config.json: | |||
There was a problem hiding this comment.
Also need the right filename, I think:
Suggested change
| jupyter_notebook_config.json: | |
| jupyter_server_config.json: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out just setting it on NotebookApp doesn't set it on ServerApp now, and so all of our templates were actually just no-ops for a while.
Discovered while testing #3178