Add password check on authenticator

jupyterhub · Jan 9, 2019 · 03c8f29 · 03c8f29
1 parent cd2c756
commit 03c8f29
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/nativeauthenticator/nativeauthenticator.py b/nativeauthenticator/nativeauthenticator.py
@@ -20,7 +20,9 @@ def __init__(self, *args, **kwargs):
 
     @gen.coroutine
     def authenticate(self, handler, data):
-        return data['username']
+        user = UserInfo.find(self.db, data['username'])
+        if user.is_valid_password(data['password']):
+            return data['username']
 
     def get_or_create_user(self, username, password):
         user = User.find(self.db, username)

diff --git a/nativeauthenticator/orm.py b/nativeauthenticator/orm.py
@@ -1,3 +1,4 @@
+import bcrypt
 from sqlalchemy import (
     Column, Integer, String
 )
@@ -18,3 +19,7 @@ def find(cls, db, username):
         Returns None if not found.
         """
         return db.query(cls).filter(cls.username == username).first()
+
+    def is_valid_password(self, password):
+        encoded_pw = bcrypt.hashpw(password.encode(), self.password)
+        return encoded_pw == self.password