ci: transition from circleci to github workflows #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
15 tasks
|
I've talked with @leportella about this and while she can't invest much work in this at the moment, we're happy to move forward as suggested. Is there anything besides merging the two remaining PRs that I need to do to make the CI work? |
|
@lambdaTotoro thanks for review / merge! I mentioned two action points in #133 but other than that everything is good to go I think. I'll happily follow up if there are failures in GitHub actions when they have started running as well.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JupyterHub organisation has transitioned to use GitHub workflows in general. I'd like to setup some other automation as well where I'll want to use github workflows copy-pasted from other repo's, so then we have it all in one system.