Systematic refresh of templates #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- General consistency across files: scripts, names, attributes, etc. - Improves readability in templates - Fixes vertical spacing issues - Fixes broken tabindex ordering - Adds autofocus to the username field in the signup template
|
Ah, yes, this looks very good. Happy to merge, many thanks @consideRatio! |
|
Wiee thanks for review/merge @lambdaTotoro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this larger set of changes can be accepted as one whole, I want to clarify why there are soo many kinds of changes.
So originally I wanted to fix: vertical spacing bugs, tabindex ordering bugs, and a missing autofocus bug. But then I also noted some inconsistencies in formatting namings between the .html files. So, I opted to fix the inconsistencies at the same time as I made the other changes. I figured it would have been impossible to separate out such changes into separate PRs, and that it would be too error prone / too much work to do all changes in sequence.
So, here I am, with a quite clobbered PR that I summarize like this:
I've also recorded two GIF animations to demonstrate a few of the changes before and after the changes were made to the templates.