pre-commit: apply black formatting #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nah, I like the string normalisation, and between the two options, I think it's sensible to use Thanks for setting this up, preparing it and making it easy to review @consideRatio ! |
|
Thanks for being so quick and responsive to review PRs @lambdaTotoro!! ❤️ 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup PR to #173 that added the .pre-commit-config.yaml file that also defines that
blackshould run. I wanted to make the changes made by black into a separate PR as they are harder to overview and would otherwise clutter the changes observed in #173.To review this, I suggest looking at the individual commits in order.
Also note that string normalization to use
"systematically instead of a mix of"and'is something that we can opt to not do while still being in compliance with general practices in the JupyterHub org, where we sometimes have enforced it and sometimes haven't enforced it. Due to that, I made it a separate commit that can be easily reviewed/removed from this PR.With regards to string normalization, I suggest we go with whatever your gut feeling tells you at this point in time @lambdaTotoro.