Add check if user exceeded attempt of logins #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leportella
force-pushed
the
block-user-after-x-failed-logins
branch
from
a3b1f33
to
b04f63d
Compare
leportella
changed the title
yuvipanda
requested changes
Jan 23, 2019
| @@ -25,13 +41,40 @@ def add_new_table(self): | |||
| User.info = relationship(UserInfo, backref='users') | |||
| UserInfo.__table__.create(self.db.bind) | |||
|
|
|||
| def exceed_atempts_of_login(self, username): | |||
There was a problem hiding this comment.
This method does two things:
- Check if the user has exceeded their limit
- Record that the user has attempted a log in
Instead, this should be three functions:
- Records that the user has attempted to log in (mutating the dictionary)
- Check if the user has exceeded their limit (check the dictionary)
- Reset user's entry in dictionary after a successful login
This clearly separates different actions on the data, making it easier to understand in the longer run.
The previous version to check if a user exceeded a number of failed logins everything was checked in a single method. This commit splits the responsabilities between 4 functions with small responsabilites each
leportella
force-pushed
the
block-user-after-x-failed-logins
branch
from
eed363c
to
3197739
Compare
yuvipanda
approved these changes
Jan 23, 2019
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21