fix orm for support mysql #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00Kai0
force-pushed
the
fix-mysql-support
branch
from
365580b
to
51f7729
Compare
|
@00Kai0 sorry for taking so long! Do you mind rebasing this please? |
|
@leportella Sorry to reply to you so late. I have rebase it. |
|
Just ran into this error today. Thanks for the fix @00Kai0 |
|
@leportella can you guys merge this and create a release please? I'm currently blocked by it and would love to use this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @leportella
The issue is
sqlalchemy.exc.CompileError: (in table 'users_info', column 'username'): VARCHAR requires a length on dialect mysql.We must declare length for
StringorUnicodein mysql.