-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add circleci for flake8 #7
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
008c039
Add circleci for flake8
leportella 3d1df26
Change circle ci identation
leportella 0297322
Add flake8 install on circle ci as sudo command
leportella 71f8974
Add install of dev-dependencies on circle ci
leportella 0bd1c69
Add dev-requirements file
leportella 1f54938
Add working dir on circleci config file
leportella 4b7f76b
Add checkout to circleci config file
leportella 7176b77
Add flake8 to dev dependencies
leportella df84010
Merge branch 'master' into add-circle-ci-config
leportella 89b8326
Add tests on circleci pipeline
leportella 80dc86a
Merge branch 'add-circle-ci-config' of github.com:jupyterhub/nativeau…
leportella 5527a02
Move tests folder from root to project folder
leportella c6bfe9a
Add which folder to run pytest on circleci
leportella 5ca982c
Add init file on tests folder
leportella 02ccfec
Add install of NativeAuth on CircleCi
leportella cf0efad
Separeted install commands on Circle Ci
leportella File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
version: 2.0 | ||
jobs: | ||
build: | ||
docker: | ||
- image: circleci/python:3.7.0 | ||
working_directory: ~/nativeauthenticator | ||
steps: | ||
- checkout | ||
- run: | ||
name: Installing dependencies | ||
command: sudo pip install -r dev-requirements.txt | ||
- run: | ||
name: Running flake8 | ||
command: flake8 . | ||
- run: | ||
name: Running tests | ||
command: pytest nativeauthenticator |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
pytest | ||
pytest-asyncio | ||
flake8 |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You likely want to
pip install .
here as well. Sudo might not be required if you use--user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To expand a little bit:
pip install .
will install package insetup.py
in current directory (.
). Currently the error in CircleCI seems to be:This is because the JupyterHub package is specified as part of install_requires in setup.py, but not in dev-requirements.txt. setup.py is the correct place for it, but we should use pip to run it before testing here.