Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix timedelta.seconds misuse #82

Merged
merged 1 commit into from
Feb 20, 2020
Merged

fix timedelta.seconds misuse #82

merged 1 commit into from
Feb 20, 2020

Conversation

meownoid
Copy link
Contributor

@meownoid meownoid commented Sep 2, 2019 •
edited
Loading

timedelta.seconds is the number of seconds in the remaining day and is always < 86399. What you meant is timedelta.total_seconds()

See: https://stackoverflow.com/questions/51652952/python-timedelta-seconds-vs-total-seconds

@leportella leportella merged commit 41f91f8 into jupyterhub:master Feb 20, 2020
@leportella
Copy link
Collaborator

Thanks @meownoid

@leportella leportella mentioned this pull request Feb 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meownoid @leportella