javascript error in https://jupyterhub.github.io/nbgitpuller/link.html

[akhmerov]

Bug description

The link generator https://jupyterhub.github.io/nbgitpuller/link.html does not work because of jquery error.

Actual behaviour

Upon opening the link generator page I see

How to reproduce

1. Go to https://jupyterhub.github.io/nbgitpuller/link.html
2. View your browser dev tools console

[welcome]

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.

You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[yuvipanda]

I think this is from #126, probably a clash of the js the theme uses vs what the link generator needs.

We should separate those two out. In the meantime, probably revert the PR

[choldgraf]

I think that while #126 did introduce a clash in the jquery / javascript, but I don't think it's causing the bug @akhmerov is experiencing

Instead, I think #49 introduced an extra field (content-repo) to the binder tab of the form. It seems that the other tabs are considering this field "required" and so they don't display the link unless that field is filled in. That's the bug we should fix.

[manics]

#133 appears to be one way of fixing it. That's not to say it's the best way, or that it's hiding some other bug!