adding a link generator binder #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great minds think alike, https://github.com/ryanlovett/gitpullapp. At the time however, @yuvipanda had wanted to keep the app and the nb extension separate. Yuvi, any new thoughts on this? |
|
ha, nice! I like yours better, shall I close this? (feel free to close if you like!) I can always make PRs to that repo. |
|
I do think that it makes sense to put the app in this repo, but I'll defer to Yuvi. |
|
Ah, I think this is ok. @ryanlovett I thought you meant putting it in the nbgitpuller extension itself, not this repo. I apologize for the misunderstanding! This is totally ok! BTW, @choldgraf - My 'inferentialthinking.com link generator' is actually riffed off of Ryan's app! |
|
haha - then we have come full-circle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this riffs off of @yuvipanda 's "inferentialthinking" binder generator, but now for generic nbgitpuller links!
you can demo it here:
https://mybinder.org/v2/gh/choldgraf/gitautosync/link_gen?urlpath=apps/binder%2Flink_generator.ipynb