Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHubOAuthenticator: check org_whitelist using check-membership api #227

Merged
merged 2 commits into from
Feb 25, 2019

Conversation

xuwaters
Copy link
Contributor

@xuwaters xuwaters commented Nov 8, 2018

Implement org_whitelist check using GitHub api check-membership
#226

@manics
Copy link
Member

manics commented Nov 12, 2018

Unfortunately I haven't got time to test this at the moment. As mentioned in #226 (comment) the rules for getting the existing org authentication to work was complicated and took a lot of investigation with regards to public/private membership, different authenticator scopes, and permissions on the GitHub org. Could you outline what configs you have or haven't tested?

@minrk minrk merged commit 64ab919 into jupyterhub:master Feb 25, 2019
@minrk
Copy link
Member

minrk commented Feb 25, 2019

I was able to test this and it worked even better than I thought. In requesting read:org access I specifically elected not to grant read-access to the orgs that require such opt-ins to see how that would fail. I was able to still login based on my membership in those organizations, even though I hadn't granted jupyterhub read-access to those orgs, so I couldn't see the full user list. So even without granting read access to the org membership list, you can check the authorized user's membership in the organization.

I went ahead and added some debug-logging to the process, which helped me verify that this is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants