-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require a minimum systemd version ? #116
Comments
Can we add Centos or other RHEL clone to that list? |
+1 to 237 |
@manics I added centos and rocky, where their v8 v9 aligned with the systemd version used. If we require 237+, then systemdspawner 1.0.0 would work in ubuntu 18+ centos/rocky 8+, fedora 28+, debian 10+. I think this is acceptable. |
I'd recommend being less conservative. Old Fedora releases don't matter, since Fedora only supports an old release for a few months after a new release is made. Anything older than Fedora 36 go into the calculation. Debian 10 has reached EoL last August and is currently in LTS until next June. Since the release of Debian 12 will be in two weeks, I'd recommend looking at that either. The pertinent point pushing you to 237 would be Ubuntu 18.04 LTS, though. It reached EoL last month. While 239 is ancient, it's still better than 237. :) |
Happy to see you chime in @behrmann!! Okay here are some lower bounds of relevance:
For reference, note that the TLJH distribution of jupyterhub is helping out testing systemdspawner, and does so with what its compatible with - debian 11+ and ubuntu 20.04+. I think if we increase the requirement, the key value is that we can more easily ensure we successfully test the lower bound. Setting up very old test environments are far harder than setting up new ones based on my experience doing this for centos7 etc in the dask/dask-gateway project. Not being a user of this project besides via being a maintainer for the TLJH distribution of jupyterhub that makes use of it, i favor a high lower bound overall. SuggestionWe fail on <237 (EDIT: <235 is known to not support all features, lets go with that), and warn on <245 that this project is only ensuring support for 245+. |
Sounds sensible to me. |
@manics @yuvipanda @behrmann wdyt?
RequirementsSystemd and Linux distributionsSystemdSpawner 1 is recommended to be used with systemd version 245 or higher,
The command |
Seems fine. I'd drop Fedora from the docs and just mention the LTS distros. However if someone reports a bug with Fedora (because it's got a newer version of systemd) we should fix it since it'll hit the more stable distros. |
In #106 (comment) @yuvipanda suggested:
This matches testing against systemd 245 as in #117! |
As part of releasing 1.0.0, I think we should check the systemd version and fail if its not above a lower limit. If we for example require systemd 235+ then all SystemdSpawner's existing config features are supported, and we have a lower version to run test againsts.
List of systemd versions with various linux distributions: https://repology.org/project/systemd/versions
I suggest we declare a lower bound on 237 at least and slim down the readme file to just say that is required at least, then we also test against ubuntu 18.04's systemd versioned 237.
Related
Current README notes
The text was updated successfully, but these errors were encountered: