Require systemd v243+, recommend systemd v245+, test against systemd v245 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
consideRatio
force-pushed
the
pr/update-systemd-notes
branch
from
6558db4
to
90254b1
Compare
consideRatio
force-pushed
the
pr/update-systemd-notes
branch
from
90254b1
to
e9491db
Compare
consideRatio
changed the title
consideRatio
force-pushed
the
pr/update-systemd-notes
branch
from
11e481f
to
e69bb32
Compare
consideRatio
changed the title
consideRatio
changed the title
consideRatio
changed the title
This was referenced May 25, 2023
Merged
consideRatio
changed the title
We should test against ubuntu's second most recent LTS release, or lower.
consideRatio
force-pushed
the
pr/update-systemd-notes
branch
from
e69bb32
to
1e2aeb1
Compare
minrk
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes existing requirements explicit, but doesn't increase them. Due to that, its not really breaking.
Changes
This isn't breaking because v0.17 is already broken for systemd version <243 because the OOMPolicy config set in Don't kill the whole service when a single proces OOMs #101 was [introduced in systemd version 243] (systemd/systemd@afcfaa6) and makes user servers fail to start.
This is motivated by us only testing on systemd version 245.
Version 245 is easy for us to test against, because its part of Ubuntu 20.04. Yuvi suggested testing against the second most newest ubuntu LTS release's systemd version, which is a perfect policy in my mind because of the environments provided by CI systems like GitHub Actions. In GitHub actions, Ubuntu 20.04 and 22.04 is available, but Ubuntu 18.04 isn't available any more and was removed a while after 22.04 had been added.
Related