Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache check of systemd version #132

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Cache check of systemd version #132

merged 1 commit into from
Jun 8, 2023

Conversation

consideRatio
Copy link
Member

No description provided.

@consideRatio consideRatio self-assigned this Jun 8, 2023
minrk
minrk approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! FWIW, in chat I was talking about caching the whole check, including the messages, not just the retrieval of the version.

@consideRatio
Copy link
Member Author

Ah, I figured it could make sense to let the message logic be out of scope of the more narrow purpose of the function, tightly scoped to just get the version as compared to also including log messages and possible logic on what to do if the version is too low etc.

I'm not confident on a change to make as a followup myself, but I'm happy to merge a change you think makes sense!

@consideRatio consideRatio merged commit ba5d382 into jupyterhub:main Jun 8, 2023
@consideRatio consideRatio mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minrk minrk minrk approved these changes

Assignees

@consideRatio consideRatio

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@consideRatio @minrk