Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /opt/tljh/user/bin to PATH #413

Closed
wants to merge 1 commit into from
Closed

Conversation

wqh17101
Copy link

@wqh17101 wqh17101 commented Aug 7, 2019

this pr does not need doc and tests

this pr is to fix #412

contains

add /opt/tljh/user/bin to PATH
add .idea to .gitignore for Pycharm project

@wqh17101
Copy link
Author

wqh17101 commented Aug 7, 2019

@GeorgianaElena @yuvipanda @minrk please review

@consideRatio
Copy link
Member

I find this change tricky to review, I lack too much knowledge about how things are supposed to work and such.

I hope someone else can review it for now. Note that there is a merge conflict related to the change introduced in #511.

<<<<<<< issue-412
# Set up image to be useful out of the box for development & CI
ENV TLJH_BOOTSTRAP_DEV=yes
ENV TLJH_BOOTSTRAP_PIP_SPEC=/srv/src
ENV PATH=/opt/tljh/user/bin:/opt/tljh/hub/bin:${PATH}
=======
# Uncomment these lines for a development install
#ENV TLJH_BOOTSTRAP_DEV=yes
#ENV TLJH_BOOTSTRAP_PIP_SPEC=/srv/src
#ENV PATH=/opt/tljh/hub/bin:${PATH}
>>>>>>> master

@manics
Copy link
Member

manics commented Oct 18, 2021

It's quite an old issue. Based on the name of the directory /opt/tljh/user/bin I'd have thought it's only for the user environment not the system environment, which implies it shouldn't be set globally.

@minrk
Copy link
Member

minrk commented Oct 22, 2021

I don't believe the user env should be on the path for running tljh. At least it shouldn't be ahead of the hub env. This PR only changes the env for the test Dockerfile, not in a place that would affect actual installs.

I think both this and #412 can be closed. This issue is covered in the docs. If anything, we could add more detail about explicitly installing in the user env independent of $PATH at the time, e.g.:

conda install -p /opt/tljh/user PACKAGE
/opt/tljh/user/bin/pip install PACKAGE

@minrk minrk closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/opt/tljh/user/bin is missing in the $PATH
4 participants