Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Docker Compose for the development environment #649

Closed
wants to merge 1 commit into from

Conversation

afeld
Copy link

@afeld afeld commented Jan 9, 2021

Combines the building of the image and the starting of the container into a single simpler command.

  • Add / update documentation
  • Add tests

Simplifies the building of the image and the starting of the container.
@welcome
Copy link

welcome bot commented Jan 9, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@consideRatio
Copy link
Member

Thanks for the suggestion @afeld!

I'm thinking this adds more complexity than it benefits the maintenance efforts of this repo, and would due to that not like to merge this change. If I were more familiar with docker compose I may think it became easier, but I'm not very familiar with it to work with it at ease.

I've just spent a lot of time in the CI system and would say there is plenty of complexity in general to run our tests because of the nature of the project. It has a script to install a python package, which then itself installs apt-get and python packages etc, which then should be running successfully - it is tricky!

@GeorgianaElena @yuvipanda what do you think?

@manics
Copy link
Member

manics commented Oct 20, 2021

docker-compose is good when you need to orchestrate multiple containers.

There's only one container here, so could you perhaps outline the advantages and disadvantages of using docker-compose over a wrapper script that does the build and run?

@consideRatio
Copy link
Member

Thank you for the contribution @afeld, but at this point we would like to retain the current setup as it is!

@jonasjancarik
Copy link

There's only one container here, so could you perhaps outline the advantages and disadvantages of using docker-compose over a wrapper script that does the build and run?

One advantage is "declarative configuration": with docker-compose.yml, you can define the container's configuration in a file, which makes it easy to understand, version, and share the container's configuration with others. This also makes it simple to update the container's configuration and apply those changes consistently across different environments.

In our environment we tend to launch everything with docker compose precisely because it's easier for the next person to figure out how exactly a container was launched. When you use docker run, the next person may have a hard time figuring out exactly how you set the container up (they'll have to use docker inspect etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants