Create link between WrapSpawner and its child spawner traitlets #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues #24, #25 and #26.
It uses
traitlets.directional_link
[1] to make any change done on WrapSpawner's traitlets also done on the child spawner's traitlets for the traitlets that both classes share.#25 -
current_port
is not an attribute ofWrapSpawner
, but I will also submit a patch for BatchSpawner that remove that traitlet in favor of only usingport
.[1] https://traitlets.readthedocs.io/en/stable/utils.html#traitlets.directional_link